[libvirt] [PATCH 1/2] virsh: Accept iface alias for domifstats too

[Ján Tomko]

On Wed, Jun 07, 2017 at 05:41:29PM +0200, Michal Privoznik wrote:
>https://bugzilla.redhat.com/show_bug.cgi?id=1459091
>
>Not every interface has a name (for instance, vhostuser
>interfaces might not have one). However, all interfaces have
>aliases. We can accept those to uniquely identify interfaces.
>

The documentation of virDomainInterfaceStats says:
The path parameter is the name of the network interface.

Overloading it to include alias introduces ambiguity.
APIs should be unambiguous if possible. Maybe it's time for a new one?

Jan

>Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
>---
> src/qemu/qemu_driver.c       | 6 ++++--
> tools/virsh-domain-monitor.c | 3 ++-
> 2 files changed, 6 insertions(+), 3 deletions(-)
>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20170608/a8f542be/attachment-0001.sig>