[libvirt] [PATCH] maint: update to latest gnulib

Martin Kletzander mkletzan at redhat.com
Wed Jun 14 13:27:25 UTC 2017

On Wed, Jun 14, 2017 at 11:20:44AM +0100, Daniel P. Berrange wrote:
>This fixes an incompatibility with glibc 2.25.90
>Signed-off-by: Daniel P. Berrange <berrange at redhat.com>
>Pushed as a broken build fix to get CI back online

After this update the build fails for me with gcc-7.1.0 with the
following error:

In file included from util/virobject.c:28:0:
util/virobject.c: In function 'virClassNew':
util/viratomic.h:176:46: error: this condition has identical branches [-Werror=duplicated-branches]
             (void)(0 ? *(atomic) ^ *(atomic) : 0);                      \
util/virobject.c:144:20: note: in expansion of macro 'virAtomicIntInc'
     klass->magic = virAtomicIntInc(&magicCounter);

Does that mean that gcc does optimize our prefetch trick away
(considering I understood what that line is trying to do)?  Or should we
just turn the warning off for that header file?

> .gnulib | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>diff --git a/.gnulib b/.gnulib
>index da830b5..ce4ee4c 160000
>--- a/.gnulib
>+++ b/.gnulib
>@@ -1 +1 @@
>-Subproject commit da830b5146cb553ac2a4bcfe76caeb57bda24cc3
>+Subproject commit ce4ee4cbb596a9d7de2786cf8c48cf62a4edede7
>libvir-list mailing list
>libvir-list at redhat.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20170614/9d3ccfdd/attachment-0001.sig>

More information about the libvir-list mailing list