[libvirt] [PATCH RFC 2/2] Resctrl: Add uitls functions to operate sysfs resctrl

[Eli Qiao]

On Tuesday, 20 June 2017 at 8:39 PM, Martin Kletzander wrote:

> On Mon, Jun 12, 2017 at 05:48:41PM +0800, Eli Qiao wrote:
> > This patch adds 3 major private interface.
> >  
> > virResctrlGetFreeCache: return free cache, default cache substract cache
> > allocated.
> > virResctrlSetCachetunes: set cache banks which defined in a domain.
> > virResctrlRemoveCachetunes: remove cache allocation group from the
> > host.
> >  
> > There's some existed issue when do syntax-check as I reference the cache
> > tune and cachebank definition (from conf/domain_conf.h) in
> > util/virresctrl.h.  
> >  
>  
>  
>  

>  
> Yes, util/ cannot depend on conf/ in libvirt due to various reasons.
> All the data you want to use in util/ need to be defined there. If that
> corresponds to some XML, the parsers and formatters must be in conf/.
> In rare cases, there might be need for two data structures, one in util/
> and one in conf/. I don't think that's needed in this case.
>  
>  


I can move the virDomainCacheBank definition to util/virresctrl.h

but what about the virCapsHostPtr, we need the host cache information and resctrl information
it’s defined in src/conf/capabilities.h”

Do we need to define another copy in virresctrl.h ?
  
> --
> libvir-list mailing list
> libvir-list at redhat.com (mailto:libvir-list at redhat.com)
> https://www.redhat.com/mailman/listinfo/libvir-list
>  
>  


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20170621/201a43f0/attachment-0001.htm>