[libvirt] [PATCH 0/4] Resolve a few Coverity found issues

John Ferlan jferlan at redhat.com
Wed Jun 28 11:37:34 UTC 2017

Was actually hoping the nodedev series would get reviewed, but since it
didn't the first patch fixes a problem that Coverity noted...  The other
3 patches are also things Coverity has noted and I've been holding onto
in my wait for enough Coverity issues to surface before posting queue of
things to do. The really strange thing about patch 2 is Coverity complained
on the second one, but not the first mainly because of the net->ifname
check a few lines earlier. By moving things - the complaint went away,
but the code looked better with a helper so I kept it that way.  Patch 3
is based on newer code that caught the attention, while patch 4 is a
much older change which just got buried amongst 30 others that I keep
in a false positive branch

John Ferlan (4):
  nodedev: Add check for NULL obj before call Unlock
  hotplug: Create helper to remove vport
  util: Adjust the #ifdef logic in virNetDevBridgeCreate
  test: Fix possible ap leak for VIR_TEST_PRELOAD

 src/node_device/node_device_driver.c |  3 ++-
 src/qemu/qemu_hotplug.c              | 41 +++++++++++++++++-------------------
 src/util/virnetdevbridge.c           |  3 ++-
 tests/qemucapsprobe.c                |  2 +-
 tests/testutils.c                    |  4 ++--
 tests/testutils.h                    |  6 +++++-
 6 files changed, 31 insertions(+), 28 deletions(-)


More information about the libvir-list mailing list