[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

[libvirt] [PATCH] util: removing dead code inside virstoragefile.



The host address or the socket path have already been checked at the begining 
of the function virStorageSourceParseNBDColonString(). So, when the parameter 
is not a unix socket, there is no reason to check the address again because 
if it does not exists, the logic will fail in the first IF conditional.

Signed-off-by: Julio Faracco <jcfaracco gmail com>
---
 src/util/virstoragefile.c | 7 -------
 1 file changed, 7 deletions(-)

diff --git a/src/util/virstoragefile.c b/src/util/virstoragefile.c
index b43acf6..6d8ada9 100644
--- a/src/util/virstoragefile.c
+++ b/src/util/virstoragefile.c
@@ -2635,13 +2635,6 @@ virStorageSourceParseNBDColonString(const char *nbdstr,
             goto cleanup;
 
    } else {
-        if (!backing[1]) {
-            virReportError(VIR_ERR_INTERNAL_ERROR,
-                           _("missing host name in nbd string '%s'"),
-                           nbdstr);
-            goto cleanup;
-        }
-
         if (VIR_STRDUP(src->hosts->name, backing[1]) < 0)
             goto cleanup;
 
-- 
2.7.4


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]