[libvirt] [PATCH 01/15] conf: Make error reporting in virCPUDefIsEqual optional

Pavel Hrdina phrdina at redhat.com
Tue Jun 6 07:28:13 UTC 2017


On Mon, Jun 05, 2017 at 11:26:49AM +0200, Jiri Denemark wrote:
> The function will be used in paths where mismatching CPU defs are not an
> error.
> 
> Signed-off-by: Jiri Denemark <jdenemar at redhat.com>
> ---
>  src/conf/cpu_conf.c    | 119 ++++++++++++++++++++++++++++++-------------------
>  src/conf/cpu_conf.h    |   3 +-
>  src/conf/domain_conf.c |   2 +-
>  3 files changed, 77 insertions(+), 47 deletions(-)

Isn't there a better way how to do it?  I don't like the fact that all
errors are wrapped by that *if*.

Pavel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20170606/48a620da/attachment-0001.sig>


More information about the libvir-list mailing list