[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v2 17/20] qemu: Always send persistent XML during migration



On Wed, Jun 07, 2017 at 12:56:52 +0200, Pavel Hrdina wrote:
> On Wed, Jun 07, 2017 at 10:37:42AM +0200, Jiri Denemark wrote:
> > When persistent migration of a transient domain is requested but no
> > custom XML is passed to the migration API we would just let the
> > destination daemon make a persistent definition from the live definition
> > itself. This is not a problem now, but once the destination daemon
> > starts replacing the original CPU definition with the one from migration
> > cookie before starting a domain, it would need to add more ugly hacks to
> > reverse the operation. Let's just always send the persistent definition
> > in the cookie to make things a bit cleaner.
> > 
> > Signed-off-by: Jiri Denemark <jdenemar redhat com>
> > ---
> > 
> > Notes:
> >     Version 2:
> >     - new patch (separated from the original 13/15)
> > 
> >  src/qemu/qemu_migration.c | 5 +++--
> >  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> Reviewed-by: Pavel Hrdina <phrdina redhat com>

Thanks for the reviews and forcing me to overcome my laziness :-)

Jirka


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]