[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCHv2 03/15] conf: add device_iotlb attribute to iommu



On Tue, Jun 06, 2017 at 01:36:17PM +0200, Ján Tomko wrote:
> Add a new device_iotlb attribute to the iommu device
> to control the device IOTLB support for intel-iommu.
> 
> https://bugzilla.redhat.com/show_bug.cgi?id=1283251
> ---
>  docs/formatdomain.html.in                          |  9 +++++++
>  docs/schemas/domaincommon.rng                      |  5 ++++
>  src/conf/domain_conf.c                             | 15 ++++++++++-
>  src/conf/domain_conf.h                             |  1 +
>  .../qemuxml2argv-intel-iommu-device-iotlb.xml      | 31 ++++++++++++++++++++++
>  .../qemuxml2xmlout-intel-iommu-device-iotlb.xml    |  1 +
>  tests/qemuxml2xmltest.c                            |  1 +
>  7 files changed, 62 insertions(+), 1 deletion(-)
>  create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-intel-iommu-device-iotlb.xml
>  create mode 120000 tests/qemuxml2xmloutdata/qemuxml2xmlout-intel-iommu-device-iotlb.xml
> 
> diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in
> index 07208ee..2f1e030 100644
> --- a/docs/formatdomain.html.in
> +++ b/docs/formatdomain.html.in
> @@ -7449,6 +7449,15 @@ qemu-kvm -net nic,model=? /dev/null
>                <span class="since">Since 3.4.0</span> (QEMU/KVM only)
>              </p>
>            </dd>
> +          <dt><code>device_iotlb</code></dt>
> +          <dd>
> +            <p>
> +              The <code>device_iotlb</code> attribute with possible values
> +              <code>on</code> and <code>off</code> can be used to
> +              turn on the device IOTLB descriptor.
> +              <span class="since">Since 3.5.0</span> (QEMU/KVM only)

How about we use just "iotlb"?  The IOTLB is used to store address
translation requests for devices.  The device_iotlb is kind of
misleading and we don't have to follow QEMU naming.  I would probably
change the "... device IOTLB descriptor." to something that indicates
what the IOTLB is for.  For example "... IOTLB used to cache address
translation requests from devices."

The code itself is good.

Pavel

Attachment: signature.asc
Description: Digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]