[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCHv2 05/15] qemuxml2xmltest: add virtio-options test

On Tue, Jun 06, 2017 at 01:36:19PM +0200, Ján Tomko wrote:
> Add a test case with all the virtio devices we know to demonstrate
> the addition of new options.
> https://bugzilla.redhat.com/show_bug.cgi?id=1283251
> ---
>  .../qemuxml2argv-virtio-options.xml                | 92 ++++++++++++++++++++++
>  .../qemuxml2xmlout-virtio-options.xml              | 92 ++++++++++++++++++++++
>  tests/qemuxml2xmltest.c                            |  1 +
>  3 files changed, 185 insertions(+)
>  create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-virtio-options.xml
>  create mode 100644 tests/qemuxml2xmloutdata/qemuxml2xmlout-virtio-options.xml

Some of the devices has two entries and some has only one entry.  Based
on the following patches the two entries are to demonstrate in tests
that setting it "on" works and setting it "off" works but this is not
tested for all devices.  I would either split it into two patches where
one would test "on" and second one "off" or just test the "on" part and
have only one patch.


Attachment: signature.asc
Description: Digital signature

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]