[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 02/26] conf: Make virDomainPCIAddressSetGrow() private



On 06/02/2017 12:07 PM, Andrea Bolognani wrote:
> There are no external users.
> ---
>  src/conf/domain_addr.c   | 2 +-
>  src/conf/domain_addr.h   | 5 -----
>  src/libvirt_private.syms | 1 -
>  3 files changed, 1 insertion(+), 7 deletions(-)
> 
> diff --git a/src/conf/domain_addr.c b/src/conf/domain_addr.c
> index 639168e..9c809e8 100644
> --- a/src/conf/domain_addr.c
> +++ b/src/conf/domain_addr.c
> @@ -362,7 +362,7 @@ virDomainPCIAddressBusSetModel(virDomainPCIAddressBusPtr bus,
>   *  0 = no action performed
>   * >0 = number of buses added
>   */
> -int
> +static int
>  virDomainPCIAddressSetGrow(virDomainPCIAddressSetPtr addrs,
>                             virPCIDeviceAddressPtr addr,
>                             virDomainPCIConnectFlags flags)
> diff --git a/src/conf/domain_addr.h b/src/conf/domain_addr.h
> index f884b8a..efa97ca 100644
> --- a/src/conf/domain_addr.h
> +++ b/src/conf/domain_addr.h
> @@ -145,11 +145,6 @@ bool virDomainPCIAddressSlotInUse(virDomainPCIAddressSetPtr addrs,
>                                    virPCIDeviceAddressPtr addr)
>      ATTRIBUTE_NONNULL(1) ATTRIBUTE_NONNULL(2);
>  
> -int virDomainPCIAddressSetGrow(virDomainPCIAddressSetPtr addrs,
> -                               virPCIDeviceAddressPtr addr,
> -                               virDomainPCIConnectFlags flags)
> -    ATTRIBUTE_NONNULL(1) ATTRIBUTE_NONNULL(2);
> -
>  int virDomainPCIAddressReserveAddr(virDomainPCIAddressSetPtr addrs,
>                                     virPCIDeviceAddressPtr addr,
>                                     virDomainPCIConnectFlags flags)
> diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms
> index 429b095..901cc99 100644
> --- a/src/libvirt_private.syms
> +++ b/src/libvirt_private.syms
> @@ -113,7 +113,6 @@ virDomainPCIAddressReserveNextAddr;
>  virDomainPCIAddressSetAllMulti;
>  virDomainPCIAddressSetAlloc;
>  virDomainPCIAddressSetFree;
> -virDomainPCIAddressSetGrow;
>  virDomainPCIAddressSlotInUse;
>  virDomainPCIAddressValidate;
>  virDomainPCIControllerModelToConnectType;
> 

Reviewed-by: Laine Stump <laine laine org>

(This *is* the new hot way to say ACK, right?)


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]