[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 02/26] conf: Make virDomainPCIAddressSetGrow() private



On Mon, 2017-06-12 at 08:35 +0200, Ján Tomko wrote:
> > Reviewed-by: Laine Stump <laine laine org>
> > 
> > (This *is* the new hot way to say ACK, right?)
> 
> It is not a replacement (AFAIK only rebels like John and Pavel use it)
> and it is not an equivalent (with Reviewed-by, I assume the reviewer
> wants me to make it a part of the commit history).

Both ACK and R-B are perfectly acceptable ways to signal the
submitter you consider their code suitable for merging. As a
project we don't currently mandate or prefer either form, so
feel free to use the one you like best :)

-- 
Andrea Bolognani / Red Hat / Virtualization


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]