[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 1/3] bhyve: tests: add vnc test to bhyvexml2xmltest



  John Ferlan wrote:

> 
> 
> On 05/09/2017 07:52 AM, Roman Bogorodskiy wrote:
> > Signed-off-by: Roman Bogorodskiy <bogorodskiy gmail com>
> > ---
> >  tests/bhyvexml2xmloutdata/bhyvexml2xmlout-vnc.xml | 41 +++++++++++++++++++++++
> >  tests/bhyvexml2xmltest.c                          |  3 +-
> >  2 files changed, 43 insertions(+), 1 deletion(-)
> >  create mode 100644 tests/bhyvexml2xmloutdata/bhyvexml2xmlout-vnc.xml
> > 
> 
> Looks reasonable...
> 
> Reviewed-by: John Ferlan <jferlan redhat com>
> 
> John

Pushed, thanks!

> Curious - should uefi and net-e1000 also get xml2xml tests seeing as the
> xml2argv was added?


Yeah, I'll add some more xml2xml tests when I finish with the <driver>
thing.

Roman Bogorodskiy

Attachment: signature.asc
Description: PGP signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]