[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v2 1/2] qemuProcessBuildDestroyHugepagesPath: create path more frequently



On 06/13/2017 04:14 PM, John Ferlan wrote:
> 
> 
> On 06/13/2017 09:05 AM, Michal Privoznik wrote:
>> https://bugzilla.redhat.com/show_bug.cgi?id=1455819
>>
>> Currently, the per-domain path for huge pages mmap() for qemu is
>> created iff domain has memoryBacking and hugepages in it
>> configured. However, this alone is not enough because there can
>> be a DIMM module with hugepages configured too.
> 
> The reality is there can be multiple reasons, true?
> 
> 1. Memory backing source file
> 2. Some page in the configured hugepages list that doesn't match the
> system pagesize
> 3. Some pagesize for a DIMM module that's requesting a different page
> size than the system page size

True.

> 
>>
>> Signed-off-by: Michal Privoznik <mprivozn redhat com>
>> ---
>>  src/qemu/qemu_process.c | 31 ++++++++++++++++++++++++++++++-
>>  1 file changed, 30 insertions(+), 1 deletion(-)
>>
> 
> Reviewed-by: John Ferlan <jferlan redhat com>
> 
> John
> 

Pushed both. Thanks,

Michal


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]