[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v2 2/4] qemu: introduce chardevStdioLogd to qemu private data




On 05/29/2017 10:31 AM, Pavel Hrdina wrote:
> In QEMU driver we can use virtlogd as stdio handler for source backend
> of char devices if current QEMU is new enough and it's enabled in
> qemu.conf.  We should store this information while starting a guest
> because the config option may change while the guest is running.
> 
> Signed-off-by: Pavel Hrdina <phrdina redhat com>
> ---
> 
> Notes:
>     new in v2
> 
>  src/qemu/qemu_domain.c  | 6 ++++++
>  src/qemu/qemu_domain.h  | 3 +++
>  src/qemu/qemu_process.c | 9 +++++++++
>  3 files changed, 18 insertions(+)
> 

FWIW: This wouldn't git am -3 apply on top of tree, I found if I went
"back to" commit '880b1a2e', then I could apply.  I was mainly a random
selection, although I did also try the patch just before jtomko's series
as well.

In any case,

Reviewed-by: John Ferlan <jferlan redhat com>

John


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]