[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v2 3/4] qemu: propagate chardevStdioLogd to qemuBuildChrChardevStr



Would be nice to say something about what the commit does and why here.
The title is partially self explanatory, but the devil is in the details.

On 05/29/2017 10:31 AM, Pavel Hrdina wrote:
> Signed-off-by: Pavel Hrdina <phrdina redhat com>
> ---
> 
> Notes:
>     new in v2
>     
>     This is not required to fix the issue by the last patch in the series,
>     however it improves the code that we decide whether to use virtlogd or
>     not by checking the same variable that is updated while preparing the
>     guest start.
> 
>  src/qemu/qemu_command.c | 132 +++++++++++++++++++++++++++++++-----------------
>  src/qemu/qemu_command.h |   3 +-
>  src/qemu/qemu_process.c |   6 ++-
>  3 files changed, 93 insertions(+), 48 deletions(-)
> 

I just hope there isn't some oddball migration or restart scenario that
evades my consciousness...

Reviewed-by: John Ferlan <jferlan redhat com>

John


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]