[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] qemu: Don't try to use hugepages if not enabled



On 06/14/2017 03:27 PM, Erik Skultety wrote:
> On Wed, Jun 14, 2017 at 10:48:33AM +0200, Michal Privoznik wrote:
>> https://bugzilla.redhat.com/show_bug.cgi?id=1214369
>>
>> My fix 671d18594f4 was incomplete. If domain doesn't have
>> hugepages enalbed, because of missing condition we would still be
> 
> s/enalbed/enabled
> 
>> putting hugepages path onto qemu cmd line. Clean up the
>> conditions so that it's more visible next time.
>>
>> Signed-off-by: Michal Privoznik <mprivozn redhat com>
>> ---
>>  src/qemu/qemu_command.c                            | 12 +++++-----
>>  .../qemuxml2argv-cpu-numa-memshared.args           | 26 ++++++++++++++++++++++
>>  tests/qemuxml2argvtest.c                           |  1 +
>>  3 files changed, 33 insertions(+), 6 deletions(-)
>>  create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-cpu-numa-memshared.args
>>


> Fixes the issue described by
> https://bugzilla.redhat.com/show_bug.cgi?id=1214369#c16.
> ACK

Pushed, thanks.

Michal


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]