[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 1/2] util: implement virStrToDoubleSafe().



Great.
I sent the V2.
Do we have any possibility to create a Locale API (a virLocale API)?
Or do you think that it is much work versus few advantages?

2017-06-16 4:03 GMT-03:00 Martin Kletzander <mkletzan redhat com>:
> On Thu, Jun 15, 2017 at 05:51:42PM -0300, Julio Faracco wrote:
>>
>> Thanks to share the commit SHA, Martin.
>>
>> My only doubt is: I speak Brazilian portuguese (so pt_BR-Latin
>> America and we use comma as separator). Should libvirt consider
>> it as a separator? Or only dot? Because this approach fails to parse
>> 12,34 (12.34 US) for example.
>>
>
> Well, it depends.  In the XML it is defined hot it should look, that's
> not locale-dependent.  Migration wouldn't work between machines with
> different locales.  Where we should respect locale is anything that is
> not being parsed (and will not be parsed by any other program) and is
> meant only for reading by the user.  I haven't actually checked the
> other patch you sent, so I don't know what you were using it in the end.


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]