[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v2] qemu: Pass the number of heads even with -vga qxl



On Thu, Jun 15, 2017 at 01:42:33PM +0200, Martin Kletzander wrote:
> When added in multiple previous commits, it was used only with -device
> qxl(-vga), but for some QEMUs (< 1.6) we need to add this
> functionality when using -vga qxl as well.
> 
> Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1283207
> 
> Signed-off-by: Martin Kletzander <mkletzan redhat com>
> ---
> v2:
>  - Do not change the domain definition
>  - Adjust the code so that it looks the same as other chunks before above
> 
> v1:
>  - https://www.redhat.com/archives/libvir-list/2017-June/msg00606.html
> 
>  src/qemu/qemu_command.c                            |  7 ++++
>  .../qemuxml2argv-video-vga-qxl-heads.args          | 30 ++++++++++++++
>  .../qemuxml2argv-video-vga-qxl-heads.xml           | 47 ++++++++++++++++++++++
>  tests/qemuxml2argvtest.c                           |  3 ++
>  4 files changed, 87 insertions(+)
>  create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-video-vga-qxl-heads.args
>  create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-video-vga-qxl-heads.xml

Reviewed-by: Pavel Hrdina <phrdina redhat com>

Attachment: signature.asc
Description: Digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]