[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 3/3] Use ATTRIBUTE_FALLTHROUGH



On Tue, Jun 13, 2017 at 01:17 AM +0200, John Ferlan <jferlan redhat com> wrote:
> On 06/07/2017 04:46 AM, Marc Hartmayer wrote:
>> Use ATTRIBUTE_FALLTHROUGH, introduced by commit
>> 5d84f5961b8e28e802f600bb2d2c6903e219092e, instead of comments to
>> indicate that the fall through is an intentional behavior.
>> 
>> Signed-off-by: Marc Hartmayer <mhartmay linux vnet ibm com>
>> Reviewed-by: Boris Fiuczynski <fiuczy linux vnet ibm com>
>> Reviewed-by: Bjoern Walk <bwalk linux vnet ibm com>
>> ---
>>  src/conf/domain_conf.c       |  2 +-
>>  src/conf/nwfilter_conf.c     | 14 +++++++-------
>>  src/cpu/cpu_ppc64.c          |  2 +-
>>  src/libvirt-domain.c         |  2 +-
>>  src/libxl/libxl_conf.c       |  2 +-
>>  src/network/leaseshelper.c   |  4 ++--
>>  src/qemu/qemu_command.c      |  2 +-
>>  src/qemu/qemu_domain.c       |  4 ++--
>>  src/qemu/qemu_driver.c       |  4 ++--
>>  src/qemu/qemu_hotplug.c      |  4 ++--
>>  src/qemu/qemu_migration.c    |  2 +-
>>  src/remote/remote_driver.c   |  2 +-
>>  src/rpc/virnetservermdns.c   |  2 +-
>>  src/storage/storage_driver.c |  2 +-
>>  src/util/virconf.c           |  2 +-
>>  src/util/virhashcode.c       |  6 +++---
>>  src/util/virnetdevbridge.c   |  1 +
>>  src/util/virutil.c           | 10 +++++-----
>>  tools/virsh-domain.c         |  4 ++--
>>  tools/virsh.c                |  2 +-
>>  tools/virt-admin.c           |  2 +-
>>  21 files changed, 38 insertions(+), 37 deletions(-)
>> 
>
> Reviewed-by: John Ferlan <jferlan redhat com>
>
> John
>
> I've pushed the series...

Thanks!

> For some reason the brain cells never remember
> who has push access and who doesn't nor how to check ;-)

-- 
Beste Grüße / Kind regards
   Marc Hartmayer

IBM Deutschland Research & Development GmbH
Vorsitzende des Aufsichtsrats: Martina Koederitz
Geschäftsführung: Dirk Wittkopp
Sitz der Gesellschaft: Böblingen
Registergericht: Amtsgericht Stuttgart, HRB 243294



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]