[libvirt] [PATCH] check the return value of qemuBuildVirtioOptionsStr

Ján Tomko jtomko at redhat.com
Tue Jun 20 10:25:10 UTC 2017


Only qemuBuildFSDevStr missed the return check.
---
 src/qemu/qemu_command.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c
index 900239f05..57893cfda 100644
--- a/src/qemu/qemu_command.c
+++ b/src/qemu/qemu_command.c
@@ -2527,7 +2527,8 @@ qemuBuildFSDevStr(const virDomainDef *def,
                       QEMU_FSDEV_HOST_PREFIX, fs->info.alias);
     virBufferAsprintf(&opt, ",mount_tag=%s", fs->dst);
 
-    qemuBuildVirtioOptionsStr(&opt, fs->virtio, qemuCaps);
+    if (qemuBuildVirtioOptionsStr(&opt, fs->virtio, qemuCaps) < 0)
+        goto error;
 
     if (qemuBuildDeviceAddressStr(&opt, def, &fs->info, qemuCaps) < 0)
         goto error;
-- 
2.13.0




More information about the libvir-list mailing list