[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v3 0/2] Adding locale support for virStrToDouble().

On Wed, Jun 21, 2017 at 02:08:27PM -0300, Julio Faracco wrote:
The commits add locale support for virStrToDouble() due to differences between
the mantissa separator in different languages. For example, kernel always uses
dot to separate mantissa. An user who is using pt_BR locale (for example) uses
comma as a separator. So, this user will have problems to parse a kernel
settings using strtod() function.

One of commits move the virDoubleToStr() to virstring.* to share locale
global variables. Joining the two functions makes more sense.

Reviewed-by: Martin Kletzander <mkletzan redhat com>

I'll push it in a minute.  Thanks for the patches and patience!

Julio Faracco (2):
 util: moving virDoubleToStr() from virutil to virstring.
 util: fix locale problem with virStrToDouble().

src/util/virstring.c | 81 ++++++++++++++++++++++++++++++++++++++++++++++++++++
src/util/virstring.h |  3 ++
src/util/virutil.c   | 63 ----------------------------------------
src/util/virutil.h   |  3 --
4 files changed, 84 insertions(+), 66 deletions(-)


libvir-list mailing list
libvir-list redhat com

Attachment: signature.asc
Description: Digital signature

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]