[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] security: Don't skip relabel for all chardevs




On 06/22/2017 07:55 AM, Michal Privoznik wrote:
> Our commit e13e8808f9 was way too generic. Currently, virtlogd is
> used only for chardevs type of file and nothing else. True, we
> must not relabel the path in this case, but we have to in all
> other cases. For instance, if you want to have a physical console
> attached to your guest:
> 
>     <console type='dev'>
>       <source path='/dev/ttyS0'/>
>       <target type='virtio' port='1'/>
>     </console>
> 
> Starting such domain fails because qemu doesn't have access to
> /dev/ttyS0 because we haven't relabelled the path.

It's relabeled in my spell checker ;-)

> 
> Signed-off-by: Michal Privoznik <mprivozn redhat com>
> ---
>  src/security/security_dac.c     | 8 ++++++--
>  src/security/security_selinux.c | 8 ++++++--
>  2 files changed, 12 insertions(+), 4 deletions(-)
> 

<sigh> - I guess I was on the right track in my review of :

https://www.redhat.com/archives/libvir-list/2017-June/msg00581.html

but couldn't quite convey enough context over my concern nor truly
follow "all" the various options for chardev's and source usage in the
formatdomain description (a different problem, but suffice to say
confusing at best).

Reviewed-by: John Ferlan <jferlan redhat com>

John


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]