[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v3 13/26] conf: Parse and format <target index='...'/>



On Fri, 2017-06-23 at 12:45 -0400, Laine Stump wrote:
> > +      <dt><code>index</code></dt>
> > +      <dd>
> > +        pci-root controllers for pSeries guests will use this attribute to
> > +        record the order they will show up in the guest.
> 
> I don't think you need the first occurence of the word "will" here -
> documentation should always read as if this is the way things are now,
> it's the way things have always been, and the way they always will be in
> the future

It was not meant to indicate that the feature is not currently
available or anything like that. It sounded good in my head
and I still can't convince myself that's wrong, but you're the
native speaker here :) Consider it gone.

> (except the "Since x.y.z" tags).

Good point, I'd forgotten to include "Since 3.5.0" but I've
added it now.

-- 
Andrea Bolognani / Red Hat / Virtualization


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]