[libvirt] [PATCH v3 13/26] conf: Parse and format <target index='...'/>
Andrea Bolognani
abologna at redhat.com
Mon Jun 26 05:26:08 UTC 2017
On Sun, 2017-06-25 at 15:57 -0400, Laine Stump wrote:
> > @@ -9348,6 +9351,23 @@ virDomainControllerDefParseXML(xmlNodePtr node,
> > goto error;
> > }
> > }
> > + if (idx) {
>
> Oh wait - I thought you were going to rename this to targetIdx (both the
> locals and the member of the struct) to avoid confusion.
>
> So make my ACK conditional on that.
Yeah, that's a good idea. Consider it done.
--
Andrea Bolognani / Red Hat / Virtualization
More information about the libvir-list
mailing list