[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 1/4] HACKING: Drop from the git repository



On Mon, Jun 26, 2017 at 12:24:42 +0200, Andrea Bolognani wrote:
> Despite being a generated file, HACKING has been tracked in
> the git repository along with actual source files. As far as
> I'm aware, it's the only generated file for which that happens.
> 
> Times and times again, people[1] have committed changes to
> the source file without refreshing the generated copy at the
> same time.
> 
> The rationale for tracking the generated file is to help out
> people who just cloned the git repository looking to contribue;
> however, README-hacking already contains enough information to
> get perspective contributors to a place where they can simply
> look at docs/hacking.html instead.

NACK, there wouldn't be no sane way to look at the file without using a
browser.

I'll stop objecting if it stays autogenerated after building the
repository. I don't particulary care whether it is or isn't tracked in
git.

Attachment: signature.asc
Description: Digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]