[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v3 14/26] conf: Add 'spapr-pci-host-bridge' controller model



On 06/26/2017 01:25 AM, Andrea Bolognani wrote:
> On Sun, 2017-06-25 at 09:55 -0400, Laine Stump wrote:
>>> Adding it to the virDomainControllerPCIModelName enumeration
>>> is enough for existing code to handle it, so parsing and
>>> formatting will work without further tweaking.
>>>  
>>> Signed-off-by: Andrea Bolognani <abologna redhat com>
>>  
>> Reviewed-by: Laine Stump <laine laine org>
>>  
>> (assuming you document it in one of these other patches)
> 
> How exactly would you like it to be documented?
> 
> I looked into it before sending out v3 and found out that
> formatdomain.html already contains the following text:
> 
>   PCI controllers also have an optional subelement <model>
>   with an attribute name. The name attribute holds the name
>   of the specific device that qemu is emulating (e.g.
>   "i82801b11-bridge") rather than simply the class of device
>   ("dmi-to-pci-bridge", "pci-bridge"), which is set in the
>   controller element's model attribute. In almost all cases,
>   you should not manually add a <model> subelement to a
>   controller, nor should you modify one that is automatically
>   generated by libvirt. Since 1.2.19 (QEMU only).
> 
> So that about covers it, doesn't it? In fact, other existing
> concrete controller models such as ioh3240 are not mentioned
> at all.

Hmm. I guess I must have decided not to document the exact model names
because 1) they are hypervisor-specific, and 2) nobody should ever need
to modify them. Since the others aren't documented, I guess you
shouldn't document this one either. (Maybe someone will decide they
should all be documented and post a patch for that).


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]