[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 01/12] Revert "qemu: Support chardevs with ARM virt machines"



On Mon, 2017-06-26 at 14:01 -0400, Cole Robinson wrote:
> This reverts commit 70c9b44270f75bfb7a5701d81aa49380d139e8f0.
> 
> This commit breaks existing aarch64 machvirt configs with:
> 
>     <serial type='pty'>
>       <target port='0'/>
>     </serial>
>     <console type='pty'>
>       <target type='serial' port='0'/>
>     </console>
> 
> Which fails with:
> 
> error: Failed to start domain fedora25-aarch64
> error: internal error: process exited while connecting to monitor:
> 2017-06-26T13:55:34.726293Z qemu-system-aarch64: -chardev pty,id=charserial0:
> char device redirected to /dev/pts/5 (label charserial0)
> 2017-06-26T13:55:34.782121Z qemu-system-aarch64: -device
> isa-serial,chardev=charserial0,id=serial0: No 'ISA' bus found for device
> 'isa-serial'
> 
> Signed-off-by: Cole Robinson <crobinso redhat com>

Reviewed-by: Andrea Bolognani <abologna redhat com>

I will probably not be able to look at the rest of the series
for a few more days, so please go ahead and push this one
right away so at least the regression will be gone.

-- 
Andrea Bolognani / Red Hat / Virtualization


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]