[libvirt] [PATCH] conf: Copy loadparm in virDomainDeviceInfoCopy()

Ján Tomko jtomko at redhat.com
Tue Jun 27 09:25:47 UTC 2017


On Mon, Jun 26, 2017 at 07:13:28PM +0200, Andrea Bolognani wrote:
>Commit 54fa1b44afc8 added virDomainDeviceInfo::loadparm
>and updated virDomainDeviceInfoClear() accordingly, but
>omitted the necessary virDomainDeviceInfoCopy() changes.
>
>Signed-off-by: Andrea Bolognani <abologna at redhat.com>
>---
> src/conf/domain_conf.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>

ACK

We should probably rewrite virDomainDeviceInfo in markdown and
autogenerate the *Copy and *Clear functions by a Rust script
to avoid such mistakes in the future.

Jan
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20170627/14d721fe/attachment-0001.sig>


More information about the libvir-list mailing list