[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 1/2] qemu: Clean up long lines in virQEMUDriverConfigLoadFile



On Thu, Jun 29, 2017 at 13:17:56 +0200, Andrea Bolognani wrote:
> On Wed, 2017-06-28 at 15:30 -0400, John Ferlan wrote:
> > Keep line length <= 80 cols.
> > 
> > Signed-off-by: John Ferlan <jferlan redhat com>
> > ---
> >  src/qemu/qemu_conf.c | 93 ++++++++++++++++++++++++++++++++++------------------
> >  1 file changed, 62 insertions(+), 31 deletions(-)
> 
> I'm pretty sure we agreed that the 80 column limit is not
> something we're interested in enforcing: if anything, we're
> actually moving away from it when changing existing code.

That very much depends on the circumstances. If the line can be easily
and cleanly broken we should stick to 80. If it would break coding style
and/or not align properly I'm fine with exceding it.

In the patch above, most of the changes breaking the argument on a
second line are fine, but the line which breaks up the 'for' loop is not
okay in this regard, since most for loops are with all three arguments
on a single line.

The 80 col boudnary has a good buffer zone until it starts running into
border of various users and still motivates us to keep the lines short.

Attachment: signature.asc
Description: Digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]