[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 3/3] tests: check domain XML to libxl structures conversion




On 06/29/2017 11:08 PM, Marek Marczykowski-Górecki wrote:
> On Thu, Jun 29, 2017 at 10:06:39AM +0100, Joao Martins wrote:
>> On 06/29/2017 02:11 AM, Marek Marczykowski-Górecki wrote:
>>> libxl contains a method to dump libxl_domain_config in json format,
>>> which is really convenient for tests. Unfortunately it require
>>> libxl_ctx, which can be only created when running on Xen (wither in dom0
>>> or domU). Because of this, skip the test in other cases.
>>>
>>> For now, have just two tests, including just-introduced CPUID handling,
>>> but this commit introduces a framework for further tests of
>>> src/libxl/libxl_conf.c file.
>>
>> There's related work about this. You might wanna look at the recent Jim's series
>> (CC'in him) from a few months ago (see below). He ressurected danpb work on
>> these xml <-> libxl_domain_config conversion, and had a whole test suite for
>> that where your cpuid test would be better inserted? Patch series is here:
>>
>> https://www.redhat.com/archives/libvir-list/2017-February/msg01477.html
> 
> This looks like a much more complete solution. Indeed it would make
> sense to put this cpuid test there. Is there any reason why
> it isn't merged yet and there is no response in that thread?
> 
I guess it wasn't reviewed by folks. I was short on time with other deliverables
so that series slipped me and couldn't help much. Perhaps a resubmission to
restart discussion - It's really nice work and would greatly improve testing :)

Cheers,
Joao


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]