[libvirt] [PATCH 3/3] conf: Use consistent function name prefixes for virnodedeviceobj

Michal Privoznik mprivozn at redhat.com
Thu Mar 2 08:51:47 UTC 2017


On 03/02/2017 01:29 AM, John Ferlan wrote:
> 
> 
> On 03/01/2017 07:27 PM, John Ferlan wrote:
>> Use "virNodeDeviceObj" as a prefix for any external API in virnodedeviceobj
>>
>> Signed-off-by: John Ferlan <jferlan at redhat.com>
>> ---
>>  src/conf/virnodedeviceobj.c          | 28 ++++++++++++++--------------
>>  src/conf/virnodedeviceobj.h          | 18 +++++++++---------
>>  src/node_device/node_device_driver.c | 24 ++++++++++++------------
>>  src/node_device/node_device_hal.c    | 10 ++++------
>>  src/node_device/node_device_udev.c   | 12 ++++++------
>>  src/test/test_driver.c               | 28 ++++++++++++++--------------
>>  6 files changed, 59 insertions(+), 61 deletions(-)
>>
> 
> Ugh... Forgot to commit:
> 
> diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms
> index 8639979..aed1d3d 100644
> --- a/src/libvirt_private.syms
> +++ b/src/libvirt_private.syms
> @@ -949,11 +949,11 @@ virDomainObjListRename;
> 
> 
>  # conf/virnodedeviceobj.h
> -virNodeDeviceAssignDef;
> -virNodeDeviceFindByName;
> -virNodeDeviceFindBySysfsPath;
> -virNodeDeviceGetParentHost;
> -virNodeDeviceHasCap;
> +virNodeDeviceObjAssignDef;
> +virNodeDeviceObjFindByName;
> +virNodeDeviceObjFindBySysfsPath;
> +virNodeDeviceObjGetParentHost;
> +virNodeDeviceObjHasCap;
>  virNodeDeviceObjListExport;
>  virNodeDeviceObjListFree;
>  virNodeDeviceObjLock;
> 
> before sending...
> 

ACK series with this squashed in.

Michal




More information about the libvir-list mailing list