[libvirt] [PATCH RFC 1/4] qemu_agent: move agent into util
Jim Fehlig
jfehlig at suse.com
Fri Mar 3 01:01:31 UTC 2017
Another self-reply...
On 03/02/2017 10:58 AM, Jim Fehlig wrote:
> Sorry for the review delay.
>
> On 02/08/2017 09:44 AM, Joao Martins wrote:
>> As it could be shared with libxl which now allows channels to
>> be created. Also changed filename to match others in the same
>> directory namely to virqemuagent.{h,c}
>>
>> Signed-off-by: Joao Martins <joao.m.martins at oracle.com>
>> ---
>> po/POTFILES.in | 2 +-
>> src/Makefile.am | 2 +-
>> src/libvirt_private.syms | 21 +
>> src/qemu/qemu_agent.c | 2248 ------------------------------------------
>> src/qemu/qemu_agent.h | 123 ---
>> src/qemu/qemu_domain.h | 2 +-
>> src/qemu/qemu_driver.c | 2 +-
>> src/util/virqemuagent.c | 2248 ++++++++++++++++++++++++++++++++++++++++++
>> src/util/virqemuagent.h | 123 +++
>> tests/qemuagenttest.c | 2 +-
>> tests/qemumonitortestutils.c | 2 +-
>> tests/qemumonitortestutils.h | 2 +-
>> 12 files changed, 2399 insertions(+), 2378 deletions(-)
>> delete mode 100644 src/qemu/qemu_agent.c
>> delete mode 100644 src/qemu/qemu_agent.h
>> create mode 100644 src/util/virqemuagent.c
>> create mode 100644 src/util/virqemuagent.h
>
> I hope others will opine on this change. It seems reasonable to me and I'm
> surprised the qemu driver only needed tiny changes to accommodate moving all
> this code.
>
> [...]
>> +qemuAgentPtr qemuAgentOpen(virDomainObjPtr vm,
>> + const virDomainChrSourceDef *config,
>> + qemuAgentCallbacksPtr cb);
>> +
>> +void qemuAgentClose(qemuAgentPtr mon);
>
> Other files in src/util prefix structs and functions with "vir". I'm not sure
> how picky folks are about that. If the consensus is towards the "vir" prefix,
> perhaps it would be easier done with a follow-up after the move?
FYI, seems the "vir" prefix is preferred. See the discussion earlier today in
this thread
https://www.redhat.com/archives/libvir-list/2017-March/msg00048.html
Regards,
Jim
More information about the libvir-list
mailing list