[libvirt] [PATH V10 12/12] Resctrl: Add nodecachestats

Marcelo Tosatti mtosatti at redhat.com
Mon Mar 6 21:33:11 UTC 2017


On Mon, Mar 06, 2017 at 05:50:43PM +0800, Eli Qiao wrote:
> Add new virsh command line `nodecachestats` to expose the cache usage
> on a node.
> 
> Signed-off-by: Eli Qiao <liyong.qiao at intel.com>
> ---
>  src/libvirt_private.syms |  3 ++-
>  src/qemu/qemu_driver.c   | 12 ++++++++++
>  src/util/virresctrl.c    | 62 ++++++++++++++++++++++++++++++++++++++++++++++++
>  src/util/virresctrl.h    |  8 +++++++
>  tools/virsh-host.c       | 49 ++++++++++++++++++++++++++++++++++++++
>  5 files changed, 133 insertions(+), 1 deletion(-)

It perhaps would be good to also report the largest contiguous region
available: So that if the space is fragmented, management software
can detect the situation beforehand.

Like this perhaps:


# LD_LIBRARY_PATH=/root/git/libvirt/src/.libs/
# /root/git/virshnodegetcachestats  
ret=0 nparams=10
L3.0: free=11520, max_contiguous=X.
L3.1: free=11520, max_contiguous=X.

Or:

L3.0.free: 11520
L3.0.max_contiguous=X.
L3.1.free: 11520
L3.1.max_contiguous=X.

Not sure what is the preferred way to do this in libvirt.

Otherwise, testing looks good now.




More information about the libvir-list mailing list