[libvirt] [PATCH] qemuDomainSaveImageUpdateDef: Don't overwrite errors from virDomainDefCheckABIStability

John Ferlan jferlan at redhat.com
Tue Mar 7 19:16:53 UTC 2017



On 03/03/2017 04:55 AM, Michal Privoznik wrote:
> https://bugzilla.redhat.com/show_bug.cgi?id=1379200
> 
> When we are restoring a domain from a saved image, or just
> updating its XML in the saved image - we have to make sure that
> the ABI guests sees will not change. We have a function for that
> which reports errors. But for some reason if this function fails,
> we call it again with slightly different argument. Therefore it
> might happen that we overwrite the original error and leave user
> with less helpful one.
> 
> Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
> ---
>  src/qemu/qemu_driver.c | 8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)
> 

ACK

John




More information about the libvir-list mailing list