[libvirt] [PATCH v3] doc: Correct the default werror policy

[Martin Kletzander]

On Wed, Mar 01, 2017 at 08:44:54PM +0100, Philipp Hahn wrote:
>The documentation is plain wrong about the default write_error policy,
>as its only implemented by QEMU (src/vz/vz_utils.c is the only other
>case, which simply explodes, is anything except other then
>VIR_DOMAIN_DISK_ERROR_POLICY_DEFAULT is used).
>

Sounds like bashing about some problem.  Is there any bug somewhere?  It
does not add any useful information to the commit message, so I'll strip
it off before pushing.

So my question is; is there anything in that driver that needs fixing
WRT this patch?

>And QEMUs default is VIR_DOMAIN_DISK_ERROR_POLICY_ENOSPACE.
>
>Signed-off-by: Philipp Hahn <hahn at univention.de>
>---
>Osier Yang proposed v1 on 2011-10-24, which never got applied due to
>discussions of "enospace" vs. "enospc".
>
>v2: Remove internal QEMU default
>
> docs/formatdomain.html.in | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
>diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in
>index 02ce792..dc44a55 100644
>--- a/docs/formatdomain.html.in
>+++ b/docs/formatdomain.html.in
>@@ -2745,7 +2745,8 @@
>             how the hypervisor will behave on a disk read or write
>             error, possible values are "stop", "report", "ignore", and
>             "enospace".<span class="since">Since 0.8.0, "report" since
>-            0.9.7</span> The default setting of error_policy is "report".
>+            0.9.7</span> The default is left to the discretion of the
>+            hypervisor.<br/>
>             There is also an
>             optional <code>rerror_policy</code> that controls behavior
>             for read errors only. <span class="since">Since
>@@ -2755,8 +2756,7 @@
>             read errors. Also note that "enospace" is not a valid
>             policy for read errors, so if <code>error_policy</code> is
>             set to "enospace" and no <code>rerror_policy</code> is
>-            given, the read error policy will be left at its default,
>-            which is "report".
>+            given, the read error policy will be left at its default.
>           </li>
>           <li>
>             The optional <code>io</code> attribute controls specific
>--
>2.1.4
>
>--
>libvir-list mailing list
>libvir-list at redhat.com
>https://www.redhat.com/mailman/listinfo/libvir-list
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20170308/c81622a6/attachment-0001.sig>