[libvirt] [PATCH v3 09/18] conf: Split up virStoragePoolSourceAdapter

John Ferlan jferlan at redhat.com
Fri Mar 10 21:10:41 UTC 2017


Create typedef'd substructures and rework typedef to utilize.

Signed-off-by: John Ferlan <jferlan at redhat.com>
---
 src/conf/storage_conf.h | 38 +++++++++++++++++++++++---------------
 1 file changed, 23 insertions(+), 15 deletions(-)

diff --git a/src/conf/storage_conf.h b/src/conf/storage_conf.h
index 1723afc..1012e74 100644
--- a/src/conf/storage_conf.h
+++ b/src/conf/storage_conf.h
@@ -179,27 +179,35 @@ typedef enum {
 } virStoragePoolSourceAdapterType;
 VIR_ENUM_DECL(virStoragePoolSourceAdapter)
 
+typedef struct _virStorageAdapterSCSIHost virStorageAdapterSCSIHost;
+typedef virStorageAdapterSCSIHost *virStorageAdapterSCSIHostPtr;
+struct _virStorageAdapterSCSIHost {
+    char *name;
+    virPCIDeviceAddress parentaddr; /* host address */
+    int unique_id;
+    bool has_parent;
+};
+
+typedef struct _virStorageAdapterFCHost virStorageAdapterFCHost;
+typedef virStorageAdapterFCHost *virStorageAdapterFCHostPtr;
+struct _virStorageAdapterFCHost {
+    char *parent;
+    char *parent_wwnn;
+    char *parent_wwpn;
+    char *parent_fabric_wwn;
+    char *wwnn;
+    char *wwpn;
+    int managed;        /* enum virTristateSwitch */
+};
+
 typedef struct _virStoragePoolSourceAdapter virStoragePoolSourceAdapter;
 typedef virStoragePoolSourceAdapter *virStoragePoolSourceAdapterPtr;
 struct _virStoragePoolSourceAdapter {
     int type; /* virStoragePoolSourceAdapterType */
 
     union {
-        struct {
-            char *name;
-            virPCIDeviceAddress parentaddr; /* host address */
-            int unique_id;
-            bool has_parent;
-        } scsi_host;
-        struct {
-            char *parent;
-            char *parent_wwnn;
-            char *parent_wwpn;
-            char *parent_fabric_wwn;
-            char *wwnn;
-            char *wwpn;
-            int managed;        /* enum virTristateSwitch */
-        } fchost;
+        virStorageAdapterSCSIHost scsi_host;
+        virStorageAdapterFCHost fchost;
     } data;
 };
 
-- 
2.9.3




More information about the libvir-list mailing list