[libvirt] [PATCH v3 04/18] conf: Rework parsing in virStoragePoolDefParseSourceAdapter

Laine Stump laine at laine.org
Sun Mar 12 18:21:56 UTC 2017


On 03/12/2017 08:42 AM, John Ferlan wrote:
>
>
>>
>> (This is the first time I've seen "relnode" used to save a ctxt->node. When I look through the source, the one other place I see it is in virxml.c (other places use "node", "save_node", "oldnode", "save_ctxt", "tmpnode", and on an on). Now I'm trying to figure out what "rel" stands for but nothing comes to mind. How stupid am I?)
>>
> I can change it to tmpnode...

Nah, makes no difference to me. The "rel" must stand for something, my brain is just too muddled to figure out *what* :-)

>
> I got it from virStoragePoolDefParseSource from a piece of the patch you
> snipped out:

Yep, and whoever wrote that probably got it from the ultimate reference for using libxml2 within libvirt - virxml.c.




More information about the libvir-list mailing list