[libvirt] [PATCH v3 04/17] qemuBuildMemoryBackendStr: Reorder args and update comment
John Ferlan
jferlan at redhat.com
Tue Mar 14 13:14:32 UTC 2017
On 03/09/2017 11:06 AM, Michal Privoznik wrote:
> Frankly, this function is one big mess. A lot of arguments,
> complicated behaviour. It's really surprising that arguments were
> in random order (input and output arguments were mixed together),
> the documentation was outdated, the description of return values
> was bogus.
>
> Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
> ---
> src/qemu/qemu_command.c | 54 +++++++++++++++++++++++++++----------------------
> src/qemu/qemu_command.h | 12 +++++------
> src/qemu/qemu_hotplug.c | 4 ++--
> 3 files changed, 38 insertions(+), 32 deletions(-)
>
ACK
John
More information about the libvir-list
mailing list