[libvirt] [PATCH 01/23] qemu: driver: Don't call qemuDomainDetermineDiskChain on block jobs

Peter Krempa pkrempa at redhat.com
Wed Mar 15 16:37:13 UTC 2017


Our code calls it when starting or re-starting the domain or when
hotplugging the disk so there's nothing to be detected.
---
 src/qemu/qemu_driver.c | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
index 2032fac71..06bd442ee 100644
--- a/src/qemu/qemu_driver.c
+++ b/src/qemu/qemu_driver.c
@@ -16508,9 +16508,6 @@ qemuDomainBlockCopyCommon(virDomainObjPtr vm,
         goto endjob;
     }

-    if (qemuDomainDetermineDiskChain(driver, vm, disk, false, true) < 0)
-        goto endjob;
-
     /* clear the _SHALLOW flag if there is only one layer */
     if (!disk->src->backingStore)
         flags &= ~VIR_DOMAIN_BLOCK_COPY_SHALLOW;
@@ -16890,8 +16887,6 @@ qemuDomainBlockCommit(virDomainPtr dom,

     if (qemuDomainDiskBlockJobIsActive(disk))
         goto endjob;
-    if (qemuDomainDetermineDiskChain(driver, vm, disk, false, true) < 0)
-        goto endjob;

     if (!top)
         topSource = disk->src;
-- 
2.12.0




More information about the libvir-list mailing list