[libvirt] [PATCH v3 14/18] conf: Convert virStoragePoolSourceAdapter to virStorageAdapter

Laine Stump laine at laine.org
Wed Mar 15 21:59:57 UTC 2017


On 03/15/2017 01:59 PM, John Ferlan wrote:
> [...]
> 
>>>
>>> 4. Using virPCIDeviceAddressPtr in getSCSIHostNumber and getAdapterName.
>>> Ironically the "original" series I had passed along the
>>> virStorageAdapterSCSIHostPtr, but since it's been decreed that a
>>> src/util function cannot include a src/conf header, I had to back that off.
>>
>> But virPCIDeviceAddressPtr is defined in src/util/virpci.c. There are
>> *other* address types that are defined in conf (e.g.
>> virDomainDeviceDriveAddress), but not PCI addresses.
>>
>>
> 
> Well _virPCIDeviceAddress is in virpci.c, but virPCIDeviceAddressPtr is
> in virpci.h...


Yeah, that's what I meant. Just mistyped.





More information about the libvir-list mailing list