[libvirt] [PATCH 00/14] Add tests for virCPUUpdateLive API

[Laine Stump]

On 03/17/2017 12:36 PM, Jiri Denemark wrote:
> Jiri Denemark (14):
>   cpu_conf: Introduce virCPUDefFreeFeatures
>   cpu: Introduce virCPUExpandFeatures
>   cpu: Drop unused flags from cpuArchDecode
>   cpu: Move feature expansion out of cpuBaseline
>   cpu: Do not pass virConnectBaselineCPUFlags to cpuBaseline
>   cputest: Move instantiation of JSONDecoder in cpu-convert.py
>   cputest: Rename cpu-convert.py script as cpu-cpuid.py
>   cputest: Add cpuidIsSet helper to cpu-cpuid.py
>   cputest: Add cpuidLeaf helper to cpu-cpuid.py
>   cputest: Add "diff" command to cpu-cpuid.py
>   cputest: Generate data for virCPUUpdateLive
>   cputest: Disable TSX on broken models
>   cputest: Disable "cmt" feature unknown to QEMU
>   cputest: Add tests for virCPUUpdateLive API

Does one of these perhaps fix a segv in virCPUUpdateLive? With current
tip of master, it's being called with cpu == NULL:


Thread 5 "lt-libvirtd" received signal SIGSEGV, Segmentation fault.
[Switching to Thread 0x7f89075bf700 (LWP 21908)]
virCPUUpdateLive (arch=VIR_ARCH_X86_64, cpu=0x0,
    dataEnabled=dataEnabled at entry=0x7f88d00078e0,
dataDisabled=0x7f88d0006430)
    at cpu/cpu.c:750
750	    if (cpu->mode != VIR_CPU_MODE_CUSTOM)
(gdb) where
#0  virCPUUpdateLive (arch=VIR_ARCH_X86_64, cpu=0x0,
    dataEnabled=dataEnabled at entry=0x7f88d00078e0,
dataDisabled=0x7f88d0006430)
    at cpu/cpu.c:750
#1  0x00007f88eb3646ff in qemuProcessUpdateLiveGuestCPU (
    asyncJob=QEMU_ASYNC_JOB_START, vm=0x7f88e01e9480, driver=0x7f88e04e9450)
    at qemu/qemu_process.c:3876
#2  qemuProcessLaunch (conn=conn at entry=0x7f88d80027f0,
    driver=driver at entry=0x7f88e04e9450, vm=vm at entry=0x7f88e01e9480,
    asyncJob=asyncJob at entry=QEMU_ASYNC_JOB_START,
incoming=incoming at entry=0x0,
    snapshot=snapshot at entry=0x0, vmop=VIR_NETDEV_VPORT_PROFILE_OP_CREATE,
    flags=17) at qemu/qemu_process.c:5731
#3  0x00007f88eb364c66 in qemuProcessStart (conn=conn at entry=0x7f88d80027f0,
    driver=driver at entry=0x7f88e04e9450, vm=vm at entry=0x7f88e01e9480,
    asyncJob=asyncJob at entry=QEMU_ASYNC_JOB_START,
    migrateFrom=migrateFrom at entry=0x0, migrateFd=migrateFd at entry=-1,
    migratePath=0x0, snapshot=0x0, vmop=VIR_NETDEV_VPORT_PROFILE_OP_CREATE,
    flags=17) at qemu/qemu_process.c:5927
#4  0x00007f88eb3bf9be in qemuDomainObjStart (conn=0x7f88d80027f0,
    driver=driver at entry=0x7f88e04e9450, vm=0x7f88e01e9480,
    flags=flags at entry=0, asyncJob=QEMU_ASYNC_JOB_START)
    at qemu/qemu_driver.c:6945
#5  0x00007f88eb3c00b6 in qemuDomainCreateWithFlags (dom=0x7f88d00009f0,
    flags=0) at qemu/qemu_driver.c:6999