[libvirt] [PATCH 2/3] Debug: Remove unnecessary errors reported while parsing non-existent sysfs files.

Prerna Saxena saxenap.ltc at gmail.com
Wed Mar 22 08:02:18 UTC 2017


Sample from current logs:
error : virFileReadAll:1290 : Failed to open file '/sys/class/net/tap3/operstate': No such file or directory
error : virNetDevGetLinkInfo:1895 : unable to read: /sys/class/net/tap3/operstate: No such file or directory

These have no useful data point and are redundant.

Signed-off-by: Prerna Saxena <saxenap.ltc at gmail.com>
---
 src/util/virnetdev.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/util/virnetdev.c b/src/util/virnetdev.c
index d123248..3e2f962 100644
--- a/src/util/virnetdev.c
+++ b/src/util/virnetdev.c
@@ -1874,7 +1874,7 @@ virNetDevGetLinkInfo(const char *ifname,
     if (virNetDevSysfsFile(&path, ifname, "operstate") < 0)
         goto cleanup;
 
-    if (virFileReadAll(path, 1024, &buf) < 0) {
+    if (virFileReadAllQuiet(path, 1024, &buf) < 0 && errno != ENOENT) {
         virReportSystemError(errno,
                              _("unable to read: %s"),
                              path);
-- 
1.8.1.2




More information about the libvir-list mailing list