[libvirt] [PATCH 06/22] network: Remove null newBandwidth check from networkBandwidthUpdate

John Ferlan jferlan at redhat.com
Wed Mar 22 14:21:19 UTC 2017


The prototype requires a NONNULL argument and the only caller passes in
a non-null parameter. Besides the "else if" condition would deref it anyway.

Signed-off-by: John Ferlan <jferlan at redhat.com>
---
 src/network/bridge_driver.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/network/bridge_driver.c b/src/network/bridge_driver.c
index a753cd7..d975092 100644
--- a/src/network/bridge_driver.c
+++ b/src/network/bridge_driver.c
@@ -5468,7 +5468,7 @@ networkBandwidthUpdate(virDomainNetDefPtr iface,
     /* Okay, there are three possible scenarios: */
 
     if (ifaceBand && ifaceBand->in && ifaceBand->in->floor &&
-        newBandwidth && newBandwidth->in && newBandwidth->in->floor) {
+        newBandwidth->in && newBandwidth->in->floor) {
         /* Either we just need to update @floor .. */
 
         if (virNetDevBandwidthUpdateRate(network->def->bridge,
-- 
2.9.3




More information about the libvir-list mailing list