[libvirt] [PATCH v3 1/7] qemu: Create #define for TLS configuration setup.

Jiri Denemark jdenemar at redhat.com
Wed Mar 22 16:26:33 UTC 2017


On Fri, Mar 17, 2017 at 14:38:55 -0400, John Ferlan wrote:
> Create GET_CONFIG_TLS_CERT to set up the TLS for 'chardev' TLS setting.
> Soon to be reused.
> 
> Signed-off-by: John Ferlan <jferlan at redhat.com>
> ---
>  src/qemu/qemu_conf.c | 39 +++++++++++++++++++++++++--------------
>  1 file changed, 25 insertions(+), 14 deletions(-)
> 
> diff --git a/src/qemu/qemu_conf.c b/src/qemu/qemu_conf.c
> index 0a338d7..9db2bc3 100644
> --- a/src/qemu/qemu_conf.c
> +++ b/src/qemu/qemu_conf.c
> @@ -530,22 +530,33 @@ int virQEMUDriverConfigLoadFile(virQEMUDriverConfigPtr cfg,
>      if (virConfGetValueBool(conf, "spice_auto_unix_socket", &cfg->spiceAutoUnixSocket) < 0)
>          goto cleanup;
>  
> +#define GET_CONFIG_TLS_CERTINFO(val)                                        \
> +    do {                                                                    \
...
> +    } while (false);

"while (0)" is usually used in such macros... not a big deal, but the
semicolon must not be there.

...

ACK with the semicolon removed.

Jirka




More information about the libvir-list mailing list