[libvirt] [PATCH 02/23] util: buffer: Add API to set indentation level to a given value

Eric Blake eblake at redhat.com
Thu Mar 23 15:32:20 UTC 2017


On 03/23/2017 02:14 AM, Peter Krempa wrote:

>>
>> No testsuite addition?
> 
> For such trivial operation? I think we have pretty strong coverage of
> the indentation code. This simple setter isn't worth it IMO.

I don't see how adding one or two lines to the testsuite, to ensure we
don't break this new interface, is not worth it.  Yes, we have a lot of
good coverage already, so let's keep it good, rather than introducing
holes in the coverage as we add new stuff.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 604 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20170323/7b8e1bf0/attachment-0001.sig>


More information about the libvir-list mailing list