[libvirt] [PATCH v4 06/10] qemu: Add TLS params to _qemuMonitorMigrationParams

Jiri Denemark jdenemar at redhat.com
Fri Mar 24 14:33:19 UTC 2017


On Thu, Mar 23, 2017 at 19:02:07 -0400, John Ferlan wrote:
> Add the fields to support setting tls-creds and tls-hostname during
> a migration (either source or target). Modify the query migration
> function to check for the presence and set the field for future
> consumers to determine which of 3 conditions is being met (NULL,
> present and set to "", or present and sent to something). These
> correspond to qemu commit id '4af245dc3' which added support to
> default the value to "" and allow setting (or resetting) to ""
> in order to disable. This reset option allows libvirt to properly
> use the tls-creds and tls-hostname parameters.
> 
> Modify code paths that either allocate or use stack space in order
> to call qemuMigrationParamsClear or qemuMigrationParamsFree for cleanup.
> 
> Signed-off-by: John Ferlan <jferlan at redhat.com>
> ---
>  src/qemu/qemu_driver.c       |  4 +++-
>  src/qemu/qemu_migration.c    | 26 +++++++++++++++++++++++++-
>  src/qemu/qemu_migration.h    |  6 ++++++
>  src/qemu/qemu_monitor.c      | 11 ++++++++---
>  src/qemu/qemu_monitor.h      |  5 +++++
>  src/qemu/qemu_monitor_json.c | 21 +++++++++++++++++++++
>  tests/qemumonitorjsontest.c  | 25 ++++++++++++++++++++++++-
>  7 files changed, 92 insertions(+), 6 deletions(-)

ACK

Jirka




More information about the libvir-list mailing list