[libvirt] [PATCH] util: Fix build on FreeBSD

Roman Bogorodskiy bogorodskiy at gmail.com
Mon Mar 27 18:04:15 UTC 2017


  Jiri Denemark wrote:

> On Mon, Mar 27, 2017 at 21:58:06 +0400, Roman Bogorodskiy wrote:
> >   Jiri Denemark wrote:
> > 
> > > Signed-off-by: Jiri Denemark <jdenemar at redhat.com>
> > > ---
> > > Pushed as a trivial build-braker.
> > > 
> > >  src/util/virnetdev.c | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > 
> > > diff --git a/src/util/virnetdev.c b/src/util/virnetdev.c
> > > index 598d1c61a..486fe4cd1 100644
> > > --- a/src/util/virnetdev.c
> > > +++ b/src/util/virnetdev.c
> > > @@ -316,7 +316,7 @@ virNetDevSetMACInternal(const char *ifname,
> > >  
> > >          ret = 0;
> > >   cleanup:
> > > -        VIR_DEBUG("SIOCSIFLLADDR %s MAC=%s - %s", ifname, mac + 1),
> > > +        VIR_DEBUG("SIOCSIFLLADDR %s MAC=%s - %s", ifname, mac + 1,
> > >                    ret < 0 ? "Fail" : "Success");
> > >  
> > >          VIR_FORCE_CLOSE(s);
> > 
> > Thanks for fixing that, though it requires one more fix:
> > 
> > https://www.redhat.com/archives/libvir-list/2017-March/msg01342.html
> > 
> > (I didn't push it right away because I wasn't able to check a complete
> > build)
> 
> Oops, sorry about this. I missed that patch and just saw a build failing
> on FreeBSD for this trivial reason and didn't notice there were in fact
> two reasons. It's probably obvious that I do not have a FreeBSD
> environment at hand :-)

Yeah, I've just pushed the second part of the fix.

Roman Bogorodskiy
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 455 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20170327/ab11c990/attachment-0001.sig>


More information about the libvir-list mailing list