[libvirt] [PATCH 0/4] qemu: Add support for setting TSC frequency to enable migration with invtsc

John Ferlan jferlan at redhat.com
Mon Mar 27 18:11:24 UTC 2017



On 03/24/2017 09:25 AM, Jiri Denemark wrote:
> QEMU allows for TSC frequency to be explicitly set to enable migration
> with invtsc (migration fails if the destination QEMU cannot set the
> exact same frequency used when starting the domain on the source host).
> 
> Jiri Denemark (4):
>   conf: Fix XML parser for timer frequency
>   qemu: Add support for setting TSC frequency
>   qemu: Use virCPUCheckFeature in qemuMigrationIsAllowed
>   qemu: Allow migration with invtsc if tsc frequency is set
> 
>  src/conf/domain_conf.c                             |  2 +-
>  src/qemu/qemu_command.c                            | 16 ++++++----
>  src/qemu/qemu_migration.c                          | 28 +++++++++++------
>  .../qemuxml2argv-cpu-tsc-frequency.args            | 23 ++++++++++++++
>  .../qemuxml2argv-cpu-tsc-frequency.xml             | 35 ++++++++++++++++++++++
>  tests/qemuxml2argvtest.c                           |  1 +
>  6 files changed, 89 insertions(+), 16 deletions(-)
>  create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-cpu-tsc-frequency.args
>  create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-cpu-tsc-frequency.xml
> 

Interesting we we didn't require a test back when first committed in
'92a9e5df63' and since that was 0.8.0, we won't need some sort of
capability check either.

ACK series, but don't forget to add a news article before pushing...

John




More information about the libvir-list mailing list