[libvirt] [PATCH 2/2] conf: do not steal pointers from the pool source

Martin Kletzander mkletzan at redhat.com
Tue Mar 28 13:41:57 UTC 2017


On Tue, Mar 28, 2017 at 03:22:08PM +0200, Ján Tomko wrote:
>Since commit fcbbb28 we steal the pointer to the storage pool
>source name if there was no pool name specified.
>
>Properly duplicate the string to avoid freeing it twice.
>
>https://bugzilla.redhat.com/show_bug.cgi?id=1436400
>---
> src/conf/storage_conf.c                             |  5 +++--
> tests/storagepoolxml2xmlout/pool-logical-noname.xml | 19 +++++++++++++++++++
> tests/storagepoolxml2xmltest.c                      |  1 +
> 3 files changed, 23 insertions(+), 2 deletions(-)
> create mode 100644 tests/storagepoolxml2xmlout/pool-logical-noname.xml
>

The ACK from the previous one was meant for both patches, but I didn't
mention it for some reason.  So ACK to this one as well.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20170328/b0be3b0a/attachment-0001.sig>


More information about the libvir-list mailing list