[libvirt] [RFC PATCH 01/11] nodedev: Fix guideline violations in nodedev modules

[Erik Skultety]

On Wed, Mar 29, 2017 at 03:50:28PM +0200, Peter Krempa wrote:
> On Wed, Mar 29, 2017 at 14:51:11 +0200, Erik Skultety wrote:
> > We recently started to enforce certain guideline rule a bit more, e.g.
> > functions delimited by 2 newlines in *.c, by 1 newline in *.h, return
> > types on a separate line, etc. This patch adjusts these issues in all
> > nodedev modules.
> >
> > Signed-off-by: Erik Skultety <eskultet at redhat.com>
> > ---
> >  src/node_device/node_device_driver.c      |  29 +++-
> >  src/node_device/node_device_driver.h      |  82 +++++++----
> >  src/node_device/node_device_hal.c         |   9 ++
> >  src/node_device/node_device_linux_sysfs.c |   1 +
> >  src/node_device/node_device_linux_sysfs.h |   9 +-
> >  src/node_device/node_device_udev.c        | 233 ++++++++++++++++++------------
> >  6 files changed, 238 insertions(+), 125 deletions(-)
> >
> > diff --git a/src/node_device/node_device_driver.c b/src/node_device/node_device_driver.c
> > index 99f7bc5476..9b1c5bb5e9 100644
> > --- a/src/node_device/node_device_driver.c
> > +++ b/src/node_device/node_device_driver.c
> > @@ -47,7 +47,8 @@
> >
> >  virNodeDeviceDriverStatePtr driver;
> >
> > -static int update_caps(virNodeDeviceObjPtr dev)
> > +static int
> > +update_caps(virNodeDeviceObjPtr dev)
>
> This does not really adhere to the guidelines. Guidelines say that
> functions have to start with 'vir' prefix and use camel case. Also they
> have to contain the name of the module.

Ehm....you just shredded me here to DIN P-6 [1] at least :D, but yeah, you're
absolutely right.

Erik

[1] https://en.wikipedia.org/wiki/Paper_shredder